Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel 8] Improve syntax highlighting #12660

Merged

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 19, 2021

Q                       A
Backport 5b3ca43 (#11413)
Patch: Bug Fix?
Major: Breaking Change? Behind BABEL_8_BREAKING
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Yes, js-tokens from 4.0.0 to 6.0.0
License MIT

The first commit is from #12659, please review that PR first.

I split the changes of this PR in two commits to make the review easier: I suggest checking them one by one and disabling whitespaces diff, because the total diff is very hard to read.

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 19, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/38047/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad282f6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo force-pushed the backport/improve-syntax-highlighting branch 2 times, most recently from d898c89 to bce76d1 Compare January 20, 2021 22:20
lydell and others added 2 commits January 22, 2021 11:02
backport of 5b3ca43, part 1

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
backport of 5b3ca43, part 2

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@nicolo-ribaudo nicolo-ribaudo force-pushed the backport/improve-syntax-highlighting branch from bce76d1 to ad282f6 Compare January 22, 2021 10:03
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review January 22, 2021 10:10
@nicolo-ribaudo nicolo-ribaudo merged commit 6a96149 into babel:main Jan 22, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the backport/improve-syntax-highlighting branch January 22, 2021 16:56
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023
@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants