Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to execute util scripts #12670

Merged
merged 1 commit into from Jan 21, 2021
Merged

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 21, 2021

Currently both of those scripts can't be executed as this project removed fs-extra, from dependencies
Alternatively those scripts should be removed from source code

https://github.com/babel/babel/search?q=fs-extra

Q                       A
Fixed Issues? none
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass? no
Documentation PR Link
Any Dependency Changes? no
License MIT

@armano2 armano2 changed the title fix: allow to execute util scripts [skip ci] fix: allow to execute util scripts Jan 21, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 49007a3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 21, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 6783308 into babel:main Jan 21, 2021
@armano2 armano2 deleted the fix/util-scripts branch January 22, 2021 00:21
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants