fix(parser): throw error with wrong typescript 'export declare' #12684
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/38377/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1cb13af:
|
nicolo-ribaudo
added
area: typescript
pkg: parser
PR: Bug Fix 🐛
packages/babel-parser/test/fixtures/typescript/export/declare-invalid/options.json
Outdated
Show resolved
Hide resolved
| isDeclare && | ||
| (this.isContextual("declare") || !this.shouldParseExportDeclaration()) | ||
| ) { | ||
| throw this.raise( |
There was a problem hiding this comment.
Should we not throw here to make it recoverable?
There was a problem hiding this comment.
I'm not sure about how we could recover. What should the AST for export declare foo be?
There was a problem hiding this comment.
Yeah, you're right. Let's stick with throwing!
There was a problem hiding this comment.
Approving, pending a reply from @existentialism to #12684 (comment) (if we can easily recover we should do it).
github-actions
bot
added
the
outdated
We check if after the first
declarethere is an exportable value.