Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ts) Raise syntax error for an abstract method in non-abstract class #12686

Merged
merged 6 commits into from Jan 27, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jan 24, 2021

Q                       A
Fixed Issues? Fixes #12681
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 24, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/38575/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7e0ce31:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@sosukesuzuki sosukesuzuki added area: errors area: typescript pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jan 24, 2021
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set inAbstractClass to false when parsing a non-abstract class since class structures can be nested:

abstract class C { m() { return class { abstract method() } } }
abstract class C { p = class { abstract method() } }

@nicolo-ribaudo nicolo-ribaudo merged commit 45fdde0 into babel:main Jan 27, 2021
@sosukesuzuki sosukesuzuki deleted the fix-12681 branch January 28, 2021 13:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No syntax error for abstract methods in not abstract classes
5 participants