New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ts) Raise syntax error for an abstract method in non-abstract class #12686
Conversation
sosukesuzuki
commented
Jan 24, 2021
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #12681 |
Patch: Bug Fix? | Y |
Tests Added + Pass? | Yes |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/38575/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e0ce31:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should set inAbstractClass
to false
when parsing a non-abstract class since class structures can be nested:
abstract class C { m() { return class { abstract method() } } }
abstract class C { p = class { abstract method() } }