Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error when accessing private method without a getter #12689

Merged
merged 4 commits into from Jan 26, 2021
Merged

fix: throw error when accessing private method without a getter #12689

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5f50ef
fix: class private accessor without getter
fedeci Jan 25, 2021
2a80d72
Provide default return if 'writeOnlyError' is not available
fedeci Jan 25, 2021
803ddc9
Add warning for old `@babel/helpers`
fedeci Jan 25, 2021
523f9b3
Add missing helper call
fedeci Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/babel-helper-create-class-features-plugin/src/fields.js
View file
Open in desktop
Expand Up @@ -224,11 +224,20 @@ const privateNameHandlerSpec = {
}

if (isMethod) {
if (isAccessor) {
if (getId) {
return t.callExpression(file.addHelper("classPrivateFieldGet"), [
this.receiver(member),
t.cloneNode(id),
]);
} else if (setId) {
if (file.availableHelper("writeOnlyError")) {
return t.callExpression(file.addHelper("writeOnlyError"), [
t.stringLiteral(name),
]);
}
console.warn(
`@babel/helpers is outdated, update it to silence this warning.`,
);
fedeci marked this conversation as resolved.
Show resolved Hide resolved
}
return t.callExpression(file.addHelper("classPrivateMethodGet"), [
this.receiver(member),
Expand Down
6 changes: 6 additions & 0 deletions packages/babel-helpers/src/helpers.js
View file
Open in desktop
Expand Up @@ -875,6 +875,12 @@ helpers.readOnlyError = helper("7.0.0-beta.0")`
}
`;

helpers.writeOnlyError = helper("7.12.12")`
fedeci marked this conversation as resolved.
Show resolved Hide resolved
export default function _writeOnlyError(name) {
throw new TypeError("\\"" + name + "\\" is write-only");
}
`;

helpers.classNameTDZError = helper("7.0.0-beta.0")`
export default function _classNameTDZError(name) {
throw new Error("Class \\"" + name + "\\" cannot be referenced in computed property keys.");
Expand Down
2 changes: 1 addition & 1 deletion ...ges/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/exec.js
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ class Cl {
}

constructor() {
expect(this.#privateFieldValue).toBeUndefined();
expect(() => this.#privateFieldValue).toThrow(TypeError);
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...s/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ class Cl {
value: 0
});

this.publicField = babelHelpers.classPrivateFieldGet(this, _privateFieldValue);
this.publicField = babelHelpers.writeOnlyError("privateFieldValue");
}

}
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-runtime-corejs2/package.json
View file
Open in desktop
Expand Up @@ -60,6 +60,7 @@
"./helpers/taggedTemplateLiteral": "./helpers/taggedTemplateLiteral.js",
"./helpers/taggedTemplateLiteralLoose": "./helpers/taggedTemplateLiteralLoose.js",
"./helpers/readOnlyError": "./helpers/readOnlyError.js",
"./helpers/writeOnlyError": "./helpers/writeOnlyError.js",
"./helpers/classNameTDZError": "./helpers/classNameTDZError.js",
"./helpers/temporalUndefined": "./helpers/temporalUndefined.js",
"./helpers/tdz": "./helpers/tdz.js",
Expand Down Expand Up @@ -140,6 +141,7 @@
"./helpers/esm/taggedTemplateLiteral": "./helpers/esm/taggedTemplateLiteral.js",
"./helpers/esm/taggedTemplateLiteralLoose": "./helpers/esm/taggedTemplateLiteralLoose.js",
"./helpers/esm/readOnlyError": "./helpers/esm/readOnlyError.js",
"./helpers/esm/writeOnlyError": "./helpers/esm/writeOnlyError.js",
"./helpers/esm/classNameTDZError": "./helpers/esm/classNameTDZError.js",
"./helpers/esm/temporalUndefined": "./helpers/esm/temporalUndefined.js",
"./helpers/esm/tdz": "./helpers/esm/tdz.js",
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-runtime-corejs3/package.json
View file
Open in desktop
Expand Up @@ -59,6 +59,7 @@
"./helpers/taggedTemplateLiteral": "./helpers/taggedTemplateLiteral.js",
"./helpers/taggedTemplateLiteralLoose": "./helpers/taggedTemplateLiteralLoose.js",
"./helpers/readOnlyError": "./helpers/readOnlyError.js",
"./helpers/writeOnlyError": "./helpers/writeOnlyError.js",
"./helpers/classNameTDZError": "./helpers/classNameTDZError.js",
"./helpers/temporalUndefined": "./helpers/temporalUndefined.js",
"./helpers/tdz": "./helpers/tdz.js",
Expand Down Expand Up @@ -139,6 +140,7 @@
"./helpers/esm/taggedTemplateLiteral": "./helpers/esm/taggedTemplateLiteral.js",
"./helpers/esm/taggedTemplateLiteralLoose": "./helpers/esm/taggedTemplateLiteralLoose.js",
"./helpers/esm/readOnlyError": "./helpers/esm/readOnlyError.js",
"./helpers/esm/writeOnlyError": "./helpers/esm/writeOnlyError.js",
"./helpers/esm/classNameTDZError": "./helpers/esm/classNameTDZError.js",
"./helpers/esm/temporalUndefined": "./helpers/esm/temporalUndefined.js",
"./helpers/esm/tdz": "./helpers/esm/tdz.js",
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-runtime/package.json
View file
Open in desktop
Expand Up @@ -59,6 +59,7 @@
"./helpers/taggedTemplateLiteral": "./helpers/taggedTemplateLiteral.js",
"./helpers/taggedTemplateLiteralLoose": "./helpers/taggedTemplateLiteralLoose.js",
"./helpers/readOnlyError": "./helpers/readOnlyError.js",
"./helpers/writeOnlyError": "./helpers/writeOnlyError.js",
"./helpers/classNameTDZError": "./helpers/classNameTDZError.js",
"./helpers/temporalUndefined": "./helpers/temporalUndefined.js",
"./helpers/tdz": "./helpers/tdz.js",
Expand Down Expand Up @@ -139,6 +140,7 @@
"./helpers/esm/taggedTemplateLiteral": "./helpers/esm/taggedTemplateLiteral.js",
"./helpers/esm/taggedTemplateLiteralLoose": "./helpers/esm/taggedTemplateLiteralLoose.js",
"./helpers/esm/readOnlyError": "./helpers/esm/readOnlyError.js",
"./helpers/esm/writeOnlyError": "./helpers/esm/writeOnlyError.js",
"./helpers/esm/classNameTDZError": "./helpers/esm/classNameTDZError.js",
"./helpers/esm/temporalUndefined": "./helpers/esm/temporalUndefined.js",
"./helpers/esm/tdz": "./helpers/esm/tdz.js",
Expand Down