New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement constantSuper
, superIsCallableConstructor
and noClassCalls
assumption
#12726
Merged
nicolo-ribaudo
merged 5 commits into
babel:feat-7.13.0/babel-core-features
from
nicolo-ribaudo:assumption/super
Feb 16, 2021
Merged
Implement constantSuper
, superIsCallableConstructor
and noClassCalls
assumption
#12726
nicolo-ribaudo
merged 5 commits into
babel:feat-7.13.0/babel-core-features
from
nicolo-ribaudo:assumption/super
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/40624/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41ea699:
|
existentialism
approved these changes
Feb 3, 2021
nicolo-ribaudo
force-pushed
the
assumption/super
branch
from
February 4, 2021 22:44
7361f7a
to
e473d46
Compare
nicolo-ribaudo
force-pushed
the
feat-7.13.0/babel-core-features
branch
from
February 4, 2021 22:44
5323795
to
f1a6109
Compare
nicolo-ribaudo
changed the title
Implement
Implement Feb 10, 2021
constantSuper
, superIsCallableConstructor
and noCallClass
assumptionconstantSuper
, superIsCallableConstructor
and noClassCall
assumption
nicolo-ribaudo
force-pushed
the
assumption/super
branch
from
February 10, 2021 19:16
e473d46
to
c86468c
Compare
nicolo-ribaudo
force-pushed
the
feat-7.13.0/babel-core-features
branch
from
February 10, 2021 19:17
7d9f061
to
a081c2a
Compare
nicolo-ribaudo
force-pushed
the
assumption/super
branch
from
February 11, 2021 23:34
c86468c
to
ed503b4
Compare
nicolo-ribaudo
force-pushed
the
feat-7.13.0/babel-core-features
branch
from
February 11, 2021 23:34
a081c2a
to
3630b02
Compare
nicolo-ribaudo
force-pushed
the
assumption/super
branch
from
February 11, 2021 23:55
ed503b4
to
e91a94f
Compare
nicolo-ribaudo
changed the title
Implement
Implement Feb 11, 2021
constantSuper
, superIsCallableConstructor
and noClassCall
assumptionconstantSuper
, superIsCallableConstructor
and noClassCalls
assumption
existentialism
approved these changes
Feb 12, 2021
JLHwung
approved these changes
Feb 16, 2021
This needs rebasing to resolve merge conflicts with #12793. |
nicolo-ribaudo
force-pushed
the
assumption/super
branch
from
February 16, 2021 22:04
e91a94f
to
7b32568
Compare
jridgewell
approved these changes
Feb 16, 2021
packages/babel-helper-create-class-features-plugin/src/fields.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 21, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
May 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: assumptions
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR: #12219
RFC: babel/rfcs#5
Please see babel/rfcs#5 (comment)!