New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable allowNamespaces in transform-typescript
by default
#12765
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3ecbf22:
|
09002f2
to
4bf8ee8
Compare
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39897/ |
Is this actually a breaking change, or can we do it in a minor? |
Agreed that it can be shipped in a minor, since we are not removing this option. |
4bf8ee8
to
3ecbf22
Compare
transform-typescript
by defaulttransform-typescript
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho we are ready to enable this by default now (in 7.13.0).
We introduced namespace
support in 7.5.0 (July 2019) behind a flag because it was a big feature and we wanted people to test it as if it was a "beta".
After more than one year we got a few bug reports and we fixed them, and probably they are now as stable as any other Babel feature.
Unlike
useSpread
inpreset-react
which will be materialized in Babel 8, I don't think the TSNamespace feature is ready for that, but we can enable it by default in Babel 8 and gather more feedback.Note that
allowNamespaces
has been enabled by default inpreset-typescript
(#12460), since it was extracted frombabel-8-dev
.