Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allowNamespaces in transform-typescript by default #12765

Merged
merged 2 commits into from Feb 21, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 5, 2021

Q                       A
Fixed Issues? https://github.com/babel/notes/blob/master/2019/05/21.md#prs
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Y
Tests Added + Pass? Yes
Documentation PR Link babel/website#2449
Any Dependency Changes?
License MIT

Unlike useSpread in preset-react which will be materialized in Babel 8, I don't think the TSNamespace feature is ready for that, but we can enable it by default in Babel 8 and gather more feedback.

Note that allowNamespaces has been enabled by default in preset-typescript (#12460), since it was extracted from babel-8-dev.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ecbf22:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 5, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39897/

@nicolo-ribaudo
Copy link
Member

Is this actually a breaking change, or can we do it in a minor?

@JLHwung
Copy link
Contributor Author

JLHwung commented Feb 8, 2021

Agreed that it can be shipped in a minor, since we are not removing this option.

@JLHwung JLHwung changed the title [Babel 8] enable allowNamespaces in transform-typescript by default Enable allowNamespaces in transform-typescript by default Feb 8, 2021
@JLHwung JLHwung added area: typescript PR: New Feature 🚀 A type of pull request used for our changelog categories and removed babel-8-dev → main labels Feb 8, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho we are ready to enable this by default now (in 7.13.0).

We introduced namespace support in 7.5.0 (July 2019) behind a flag because it was a big feature and we wanted people to test it as if it was a "beta".

After more than one year we got a few bug reports and we fixed them, and probably they are now as stable as any other Babel feature.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.13.0 milestone Feb 11, 2021
This was referenced Mar 14, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants