Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @rollup/plugin-replace #12847

Merged
merged 1 commit into from Feb 22, 2021
+15 −12
Merged

Update @rollup/plugin-replace #12847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions Gulpfile.mjs
View file
Open in desktop
Expand Up @@ -292,9 +292,12 @@ function buildRollup(packages, targetBrowsers) {
plugins: [
rollupBabelSource(),
rollupReplace({
"process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
BABEL_VERSION: JSON.stringify(babelVersion),
VERSION: JSON.stringify(version),
preventAssignment: true,
values: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is not documented but it's nice since it separates options from replacements.
I opened a PR to document it (rollup/plugins#814)

"process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
BABEL_VERSION: JSON.stringify(babelVersion),
VERSION: JSON.stringify(version),
},
}),
rollupCommonJs({
include: [
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@
"@rollup/plugin-commonjs": "patch:@rollup/plugin-commonjs@^17.1.0#./.yarn/patches/@rollup__plugin-commonjs.patch",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^2.3.3",
"@rollup/plugin-replace": "^2.4.0",
"@typescript-eslint/eslint-plugin": "^4.6.1",
"@typescript-eslint/parser": "^4.6.1",
"babel-plugin-transform-charcodes": "^0.2.0",
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -3790,15 +3790,15 @@ __metadata:
languageName: node
linkType: hard

"@rollup/plugin-replace@npm:^2.3.3":
version: 2.3.3
resolution: "@rollup/plugin-replace@npm:2.3.3"
"@rollup/plugin-replace@npm:^2.4.0":
version: 2.4.0
resolution: "@rollup/plugin-replace@npm:2.4.0"
dependencies:
"@rollup/pluginutils": ^3.0.8
magic-string: ^0.25.5
"@rollup/pluginutils": ^3.1.0
magic-string: ^0.25.7
peerDependencies:
rollup: ^1.20.0 || ^2.0.0
checksum: d08a514b8f446a3fe3db7e9de7d1a57c4aaeaaa3d6f70c2e18925d893ed81480dbfd29fe939f61c1ef31194b036ab7b1df22a744ffd33196335f9fa1925d3c22
checksum: 5151bed6479eeddfb0368f21e4ebc9a872f46e0443f17e32fc9362164ab9a4fd996b0703361190d085b46fc911e5d6ae757866a318e5651583af7019b2ee533e
languageName: node
linkType: hard

Expand Down Expand Up @@ -4904,7 +4904,7 @@ __metadata:
"@rollup/plugin-commonjs": "patch:@rollup/plugin-commonjs@^17.1.0#./.yarn/patches/@rollup__plugin-commonjs.patch"
"@rollup/plugin-json": ^4.1.0
"@rollup/plugin-node-resolve": ^9.0.0
"@rollup/plugin-replace": ^2.3.3
"@rollup/plugin-replace": ^2.4.0
"@typescript-eslint/eslint-plugin": ^4.6.1
"@typescript-eslint/parser": ^4.6.1
babel-plugin-transform-charcodes: ^0.2.0
Expand Down Expand Up @@ -9744,7 +9744,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"magic-string@npm:^0.25.3, magic-string@npm:^0.25.5, magic-string@npm:^0.25.7":
"magic-string@npm:^0.25.3, magic-string@npm:^0.25.7":
version: 0.25.7
resolution: "magic-string@npm:0.25.7"
dependencies:
Expand Down