Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: downgrade semver to ^6.3.0 #12890

Merged
merged 1 commit into from Feb 24, 2021
Merged

Chore: downgrade semver to ^6.3.0 #12890

merged 1 commit into from Feb 24, 2021

Conversation

soda-x
Copy link
Contributor

@soda-x soda-x commented Feb 24, 2021 •
edited

Q                       A
Fixed Issues? Fixes #12015 (comment)
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link ba4ac7d
Any Dependency Changes?
License MIT

Ref: ba4ac7d

Downgrade semver to ^6.3.0

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42356/

nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labeling as "Dependency ⬆️", but it should be "Dependency ⬇️" 😂

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 112e151:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

kaicataldo
kaicataldo approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The irony of this PR is amazing 😆

LGTM

@nicolo-ribaudo
Copy link
Member

@kaicataldo One day I'll print and frame npm/node-semver@d61f828#r36469180 to remind myself that breaking changes are ok!

@nicolo-ribaudo nicolo-ribaudo merged commit c9da965 into babel:main Feb 24, 2021
@soda-x soda-x changed the title Chore: downgrade semver to ^6.3.2 Chore: downgrade semver to ^6.3.0 Feb 25, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soda-x @babel-bot @nicolo-ribaudo @kaicataldo