-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all the @babel/*
dependencies
#12897
Conversation
nicolo-ribaudo
commented
Feb 24, 2021
•
edited
edited
Q | A |
---|---|
Fixed Issues? | Closes #10823 |
Patch: Bug Fix? | |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
shippedProposals: true, | ||
modules: false, | ||
exclude: [ | ||
"transform-typeof-symbol", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In loose
mode preset-env
disables this plugin, but we don't have an assumption for it because it was done at the preset level. We might consider adding one in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, maybe good to note in some places if people miss it when turning off loose mode. although I guess if you are doing this you'd probably want to actually do a code diff to see the changes. Would be nice if we had a tool to help with that
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a4f6af2:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42612/ |
7d19874
to
68d21dd
Compare
68d21dd
to
a4f6af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
You might notice a warning in |