Fix esmodules: true without specified browsers
#12908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Feb 25, 2021
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #12903 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Feb 25, 2021
| @@ -205,7 +205,7 @@ export default function getTargets( | |||
|
|
|||
| // `esmodules` as a target indicates the specific set of browsers supporting ES Modules. | |||
| // These values OVERRIDE the `browsers` field. | |||
| if (esmodules && (esmodules !== "intersect" || !browsers)) { | |||
| if (esmodules && (esmodules !== "intersect" || !shouldParseBrowsers)) { | |||
There was a problem hiding this comment.
browsers was always assigned at line 194
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42798/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dda6659:
|
JLHwung
previously approved these changes
Feb 25, 2021
nicolo-ribaudo
force-pushed
the
fix-esmodules
branch
from
be5576e
to
dda6659
Compare
JLHwung
approved these changes
Mar 1, 2021
hzoo
approved these changes
Mar 1, 2021
This was referenced Mar 8, 2021
Merged
Merged
This was referenced Mar 17, 2021
Closed
Closed
Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.