New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse attributes of import expression with estree plugin #13284
Conversation
sosukesuzuki
commented
May 7, 2021
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #13280 |
Patch: Bug Fix? | Y |
Tests Added + Pass? | Yes |
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45939/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6badd7e:
|
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
"Bug Fix" might be a bit of a stretch here, but I can convince myself that this isn't a new feature by saying that we were already parsing the import attributes but accidentally dropping them completely from the AST 🤷 |
Thanks for the quick fix. |