Expose @babel/eslint-parser/experimental-worker
#13398
Conversation
nicolo-ribaudo
added
PR: New Feature 🚀
| MAYBE_PARSE_SYNC: "MAYBE_PARSE_SYNC", | ||
| }; | ||
|
|
||
| class Client { |
There was a problem hiding this comment.
I reorganized this file so that it can both run Babel using worker_threads or in the same thread. The Client class is the "public interface", while the WorkerClient and LocalClient provide the communication implementation.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed21d0b:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47762/ |
|
CI is failing because of #13399 |
nicolo-ribaudo
force-pushed
the
eslint-worker-babel-7
branch
from
08f6705
to
71d4ff5
Compare
|
The CI error seems related. |
nicolo-ribaudo
force-pushed
the
eslint-worker-babel-7
branch
3 times, most recently
from
928f6bd
to
b6a3f83
Compare
| @@ -164,12 +164,13 @@ function writeHelpers(runtimeName, { corejs } = {}) { | |||
| // - Node.js <13.2.0 will fail resolving the first array entry, and will | |||
| // fallback to the second entry (the CJS file) | |||
| // In Babel 8 we can simplify this. | |||
| helperSubExports[`./${helperPath}`] = [ | |||
| helperSubExports[`./${path.posix.join("helpers", helperName)}`] = [ | |||
There was a problem hiding this comment.
Otherwise it was using mixed / and \.
| ? it.skip | ||
| : it; | ||
|
|
||
| babel7node12("experimental worker works with babel.config.mjs", () => { |
nicolo-ribaudo
force-pushed
the
eslint-worker-babel-7
branch
from
5bd5dce
to
6d6e7be
Compare
nicolo-ribaudo
force-pushed
the
eslint-worker-babel-7
branch
from
6d6e7be
to
ed21d0b
Compare
| static #worker_threads_cache; | ||
| static get #worker_threads() { | ||
| return (WorkerClient.#worker_threads_cache ??= require("worker_threads")); | ||
| } |
There was a problem hiding this comment.
Q: What's the intention of private static getter? Doesn't static #worker_threads = require("worker_threads") work here?
There was a problem hiding this comment.
This file is always executed, but require("worker_threads") is only necessary when actually using the experimental implementation.
| static #handleMessage; | ||
|
|
||
| constructor() { | ||
| LocalClient.#handleMessage ??= require("./worker/handle-message.cjs"); |
JLHwung
added
the
PR: Ready to be Merged
github-actions
bot
added
the
outdated
Exposing the worker implementation makes it possible for our users to start testing it (and to start using mjs config files) before that we make it the default.
It was initially implemented in #13199 behind the
BABEL_8_BREAKINGflag. This PR reorganizes the implementation so that it can live side-by-side with the sync one.