parser: Fix Hack/smart-pipe error positions #13426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors for invalid topic references so that the errors point to the topic tokens themselves, rather than immediately after them. Reverts a breaking change to smart-mix pipe error positions made in babel#13191.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0182f9:
|
fedeci
added
pkg: parser
PR: Bug Fix 🐛
fedeci
approved these changes
Jun 6, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Jun 7, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Jun 8, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Jul 6, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Jul 6, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Aug 3, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Aug 3, 2021
This was referenced Aug 5, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the Hack-pipes proposal (and the deprecated smart-mix pipes proposal). It is a continuation of #13191. It fixes errors raised for invalid topic references, such that the errors point to the topic tokens themselves, rather than immediately after them.
(This therefore also reverts a breaking change to smart-mix pipe error positions made in #13191 that I had not noticed before, in which the positions of such errors were inadvertently incremented by one.)
I made this pull request separately from #13416 because it is a relatively minor change that nevertheless changes several test fixtures that are unrelated to #13416. It should probably be merged before #13416.