Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference to class expression in private method #13429

Merged
merged 6 commits into from Jun 14, 2021

Conversation

lala7573
Copy link
Contributor

@lala7573 lala7573 commented Jun 6, 2021

Q                       A
Fixed Issues? Fixes #13399
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? 👍
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 6, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46851/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fad6be1:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods labels Jun 8, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@nicolo-ribaudo
Copy link
Member

The CI / E2E (babel-old-version) failure has been fixed on main so you can safely ignore it.

remove wrapper function on test which is no need
split innerBinding from ref because ref is AST node.
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added this to To review in Nicolò's ideal PR review order list via automation Jun 10, 2021
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests lgtm!

apply feedbacks

Co-authored-by: Henry Zhu <hi@henryzoo.com>
lala7573 and others added 2 commits June 14, 2021 18:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods
Development

Successfully merging this pull request may close these issues.

[Bug]: Reference to class expression in private methods is not correctly compiled
6 participants