Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow dependency cycles #13442

Merged
merged 4 commits into from Jun 9, 2021
Merged

Disallow dependency cycles #13442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0401a1
Disallow dependency cycles
nicolo-ribaudo Jun 9, 2021
0945786
Remove cycle
nicolo-ribaudo Jun 9, 2021
ae1809a
`yarn constraints --fix`
nicolo-ribaudo Jun 9, 2021
0e454a1
Aaaaaaaaaaaaaaaaaa
nicolo-ribaudo Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -36,6 +36,9 @@ jobs:
YARN_NODE_LINKER: pnp # use pnp linker for better linking performance: it's meant to update yarn cache only
run: |
yarn install --immutable --skip-builds
- name: Check for dependency cycles
run: |
yarn release-tool check-cycles

test-coverage:
name: Test on Node.js Latest
Expand Down
4 changes: 2 additions & 2 deletions .yarn/plugins/@yarnpkg/plugin-babel-release-tool.cjs
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions packages/babel-helper-hoist-variables/package.json
View file
Open in desktop
Expand Up @@ -13,11 +13,13 @@
"access": "public"
},
"main": "./lib/index.js",
"TODO": "The @babel/traverse dependency is only needed for the NodePath TS type. After converting @babel/core to TS we can import NodePath from there.",
"dependencies": {
"@babel/traverse": "workspace:^7.13.15",
"@babel/types": "workspace:^7.13.16"
},
"TODO": "The @babel/traverse dependency is only needed for the NodePath TS type. We can consider exporting it from @babel/core.",
"devDependencies": {
"@babel/traverse": "workspace:*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traverse is only used for a type import:

babel/packages/babel-helper-hoist-variables/src/index.ts

Lines 1 to 3 in d3f4c22

import * as t from "@babel/types";
import type { NodePath } from "@babel/traverse";

},
"engines": {
"node": ">=6.9.0"
},
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -596,7 +596,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@babel/helper-hoist-variables@workspace:packages/babel-helper-hoist-variables"
dependencies:
"@babel/traverse": "workspace:^7.13.15"
"@babel/traverse": "workspace:*"
"@babel/types": "workspace:^7.13.16"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -3567,7 +3567,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/traverse@workspace:*, @babel/traverse@workspace:^7.13.0, @babel/traverse@workspace:^7.13.15, @babel/traverse@workspace:^7.14.0, @babel/traverse@workspace:^7.14.2, @babel/traverse@workspace:packages/babel-traverse":
"@babel/traverse@workspace:*, @babel/traverse@workspace:^7.13.0, @babel/traverse@workspace:^7.14.0, @babel/traverse@workspace:^7.14.2, @babel/traverse@workspace:packages/babel-traverse":
version: 0.0.0-use.local
resolution: "@babel/traverse@workspace:packages/babel-traverse"
dependencies:
Expand Down