Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone: update preset-stage-* #13476

Merged
merged 7 commits into from Aug 3, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jun 17, 2021

Q                       A
Fixed Issues? N/A
Major: Breaking Change? Y?
Minor: New Feature? Y?
Tests Added + Pass? Yes
License MIT

I'm not sure that how we should treat this PR for semantic versioning.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e4e788:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 17, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47842/

@hzoo
Copy link
Member

hzoo commented Jun 17, 2021

Yeah it's weird, we should mention we don't support stages https://babeljs.io/blog/2018/07/27/removing-babels-stage-presets since a few years ago it just happens to still be used as the api..

It's mostly for our own REPL, we should try to remove the feature entirely (just turn on all plugins or make it opt in like most people have to use it)

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as a minor.

For Babel 8, since everything will be ESM-based we might just consider dropping @babel/standalone support and relying on "exports" to differentiate between Node.js and browser code.

@nicolo-ribaudo nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jun 17, 2021
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for minor

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jun 21, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v7.15.0 milestone Jun 21, 2021
@JLHwung JLHwung changed the title fix plugins that is included in preset-stage-* standalone: update preset-stage-* Aug 3, 2021
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing stage 3 plugins is a breaking change. Because 'stage-3' no long enables the plugins that were enabled before Babel 7.15. We have to defer deletion to Babel 8. Otherwise this PR looks good to me.

@nicolo-ribaudo nicolo-ribaudo force-pushed the preset-for-proposals branch 2 times, most recently from bf8e29a to ef06c79 Compare August 3, 2021 20:59
@nicolo-ribaudo nicolo-ribaudo merged commit 13af87c into babel:main Aug 3, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants