New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standalone: update preset-stage-*
#13476
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4e4e788:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47842/ |
Yeah it's weird, we should mention we don't support stages https://babeljs.io/blog/2018/07/27/removing-babels-stage-presets since a few years ago it just happens to still be used as the api.. It's mostly for our own REPL, we should try to remove the feature entirely (just turn on all plugins or make it opt in like most people have to use it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as a minor.
For Babel 8, since everything will be ESM-based we might just consider dropping @babel/standalone
support and relying on "exports"
to differentiate between Node.js and browser code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for minor
preset-stage-*
preset-stage-*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing stage 3 plugins is a breaking change. Because 'stage-3' no long enables the plugins that were enabled before Babel 7.15. We have to defer deletion to Babel 8. Otherwise this PR looks good to me.
bf8e29a
to
ef06c79
Compare
ef06c79
to
4e4e788
Compare
I'm not sure that how we should treat this PR for semantic versioning.