feat(ts): raise error for abstract property with initializer #13523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedeci
added
area: typescript
pkg: parser
PR: Spec Compliance 👓
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb6bf4c:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47814/ |
| TSErrors.AbstractPropertyHasInitializer, | ||
| key.type === "Identifier" | ||
| ? key.name | ||
| : `[${this.input.slice(key.start, key.end)}]`, |
There was a problem hiding this comment.
Can you also add a test for this case?
nicolo-ribaudo
approved these changes
Jul 2, 2021
existentialism
approved these changes
Jul 2, 2021
existentialism
added
the
PR: Ready to be Merged
JLHwung
reviewed
Jul 2, 2021
fedeci
force-pushed
the
no-abstract-prop-init
branch
from
0ced40d
to
35db442
Compare
JLHwung
reviewed
Aug 3, 2021
nicolo-ribaudo
force-pushed
the
no-abstract-prop-init
branch
from
35db442
to
54732e9
Compare
JLHwung
reviewed
Aug 3, 2021
This was referenced Aug 5, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an error for class abstract properties with initializer as specified in TS 4.4 beta announcement.