feat(typescript): implement namespace alias #13528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support `import alias = Namespace`, reject `import alias = require('foo')`
fix babel#12345
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 21af3b4:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47200/ |
colinaaa
commented
Jul 3, 2021
fedeci
reviewed
Jul 4, 2021
lweathermon
approved these changes
Jul 4, 2021
nicolo-ribaudo
added
area: typescript
PR: New Feature 🚀
nicolo-ribaudo
approved these changes
Jul 6, 2021
|
What's the status here? should this PR be merged in |
existentialism
approved these changes
Jul 14, 2021
lweathermon
approved these changes
Jul 14, 2021
nicolo-ribaudo
added
the
PR: Ready to be Merged
|
Thanks! We'll release 7.15 this week. |
This was referenced Aug 5, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
import alias = Namespace, rejectimport alias = require('foo')Implementation is quite simple. Just replace
moduleReferencewithExpression | MemberExpression.