Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ergonomic brand checks (#priv in) by default #13554

Merged
merged 4 commits into from Aug 3, 2021
Merged

Enable ergonomic brand checks (#priv in) by default #13554

merged 4 commits into from Aug 3, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 12, 2021 •
edited

Q                       A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2556
Any Dependency Changes?
License MIT

@ljharb is going to ask for Stage 4 at this week's meeting (agenda).

We were already planning 7.15.0, but it would be very nice to get this PR in (if the feature gets Stage 4).

EDIT: Stage 4 confirmed 🎉

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Brand Check for Private Fields labels Jul 12, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dfbd40d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 12, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47345/

@nicolo-ribaudo nicolo-ribaudo added PR: Needs Docs PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release labels Jul 13, 2021
@ljharb
Copy link
Member

ljharb commented Jul 14, 2021

This proposal is now stage 4

@nicolo-ribaudo nicolo-ribaudo added this to the v7.15.0 milestone Jul 17, 2021
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 17, 2021
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit a254ea3 into babel:main Aug 3, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the ergonomic-brand-checks-by-default branch August 3, 2021 21:02
@ljharb
Copy link
Member

ljharb commented Aug 3, 2021

yay!

@nicolo-ribaudo
Copy link
Member Author

We'll release 7.15 this week, hopefully tomorrow!

This was referenced Aug 5, 2021
Merged
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@hzoo hzoo hzoo approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Brand Check for Private Fields
Projects
None yet
Milestone
v7.15.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicolo-ribaudo @babel-bot @ljharb @existentialism @hzoo @JLHwung