Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(CONTRIBUTING.md): update required node versions to ^12.20 || >= 14.13 #13580

Merged
merged 1 commit into from Jul 20, 2021
Merged

docs(CONTRIBUTING.md): update required node versions to ^12.20 || >= 14.13 #13580

merged 1 commit into from Jul 20, 2021

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Jul 20, 2021 •
edited

Node ^12.20 || >=14.13 is now required because there are MJS modules in the project that have named imports from CJS modules. Support for doing this was only added in 14.13.0 and backported to 12.20.0: nodejs/node#35249 (comment)

I ran make bootstrap on 12.20.0 and 14.13.0 and it works, whereas I saw it fail on 12.16.3 and 14.11.0

Q                       A
Fixed Issues?
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass? N/A
Documentation PR Link
Any Dependency Changes? No
License MIT

@jedwards1211
docs(CONTRIBUTING.md): update required node versions [ci skip]
dc5206e 
Node ^12.20 || >=14.13 is now required because there are MJS modules in the project
that have named imports from CJS modules.  Support for doing this was only added in
14.13.0 and backported to 12.20.0: nodejs/node#35249 (comment)
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc5206e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added PR: Docs 📝 A type of pull request used for our changelog categories and removed PR: Docs 📝 A type of pull request used for our changelog categories labels Jul 20, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit b67ea12 into babel:main Jul 20, 2021
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@jedwards1211 @nicolo-ribaudo
[build docs] Update required node versions to ^12.20 || >=14.13 (babe…
3bd3cdd 
…l#13580)
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jedwards1211 @JLHwung @nicolo-ribaudo