New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(doc): add jest specific pckg command #13607
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47804/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 206fa6f:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are equivalent flags also for TEST_GREP
and TEST_DEBUG
, why don't we document all of them?
Just to mention that the command |
TIL about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the nitpicks, I was thinking about a more tabular view of this commands, what's your point of view?
Fix nitpicks and reshape a bit the documentation. Let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits.
CONTRIBUTING.md
Outdated
@@ -82,64 +82,100 @@ $ make build-dist | |||
|
|||
### Running linting/tests | |||
|
|||
You can run lint via: | |||
#### You can run lint via: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if we want to align the language in h4 subtitles. e.g. We can simplify put "Lint" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was to add a bit of structure to all these lines. But we can rethink it. :)
Hi 👋
Yesterday, chatting with @JLHwung we figured out that the command:
yarn jest <name-of-the-pckg> --watch
wasn't mentioned in the documentation.A tiny PR to add it ^^
Let me know if it's useful or not.