Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add display name after create context (#13501)" #13637

Merged

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 5, 2021

Reverts #13501

Workaround for facebook/react-native#31960. I'll work on relanding it after that this is released.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47943/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 662801a:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@slorber
Copy link

slorber commented Aug 5, 2021

Thanks @nicolo-ribaudo latest release seems to work better.

FYI Docusaurus was also affected: facebook/docusaurus#5287

We'll try to reland this change making sure that it doesn't break. I never used React Native: is there an example app or a command I can run on Linux to reproduce the error?

In case you want to test against Docusaurus:

npx @docusaurus/init@latest init my-website classic
cd my-website
yarn start 

@lslsls0001
Copy link

Solution here, it works:
facebook/react-native#31960 (comment)

@lslsls0001
Copy link

babel/core: 7.14.5
display-name:7.14.5
make sure the version number are same

@nicolo-ribaudo
Copy link
Member Author

Now that this PR has been released, @babel/plugin-transform-react-display-name 7.15.1 works too.

JordaoViktor pushed a commit to JordaoViktor/paralenz that referenced this pull request Aug 5, 2021
…act-display-name wrong when i needed to update issue: babel/babel#13637
@Aimless397
Copy link

I solved it by using this line in CLI:
npm update @babel/plugin-transform-react-display-name

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Revert ↩️ A type of pull request used for our changelog categories Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants