Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skipTransparentExprWrapperNodes helper #13687

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -41,3 +41,12 @@ export function skipTransparentExprWrappers(
}
return path;
}

export function skipTransparentExprWrapperNodes(
node: t.Expression,
): t.Expression {
while (isTransparentExprWrapper(node)) {
node = node.expression;
}
return node;
}
14 changes: 4 additions & 10 deletions packages/babel-plugin-proposal-optional-chaining/src/transform.js
@@ -1,14 +1,14 @@
import { types as t, template } from "@babel/core";
import {
isTransparentExprWrapper,
skipTransparentExprWrapperNodes,
skipTransparentExprWrappers,
} from "@babel/helper-skip-transparent-expression-wrappers";
import { willPathCastToBoolean, findOutermostTransparentParent } from "./util";

const { ast } = template.expression;

function isSimpleMemberExpression(expression) {
expression = skipTransparentExprWrappers(expression);
expression = skipTransparentExprWrapperNodes(expression);
return (
t.isIdentifier(expression) ||
t.isSuper(expression) ||
Expand Down Expand Up @@ -103,11 +103,7 @@ export function transform(
const replaceKey = isCall ? "callee" : "object";

const chainWithTypes = node[replaceKey];
let chain = chainWithTypes;

while (isTransparentExprWrapper(chain)) {
chain = chain.expression;
}
const chain = skipTransparentExprWrapperNodes(chainWithTypes);

let ref;
let check;
Expand Down Expand Up @@ -169,9 +165,7 @@ export function transform(
// i.e. `?.b` in `(a?.b.c)()`
if (i === 0 && parentIsCall) {
// `(a?.b)()` to `(a == null ? undefined : a.b.bind(a))()`
const object = skipTransparentExprWrappers(
replacementPath.get("object"),
).node;
const object = skipTransparentExprWrapperNodes(replacement.object);
let baseRef;
if (!pureGetters || !isSimpleMemberExpression(object)) {
// memoize the context object when getters are not always pure
Expand Down
@@ -1,3 +1 @@
var _bar, _ref;

(_bar = ((_ref = (foo as A)).bar as B)) == null ? void 0 : _bar.call(_ref, foo.bar, false);
((foo as A).bar as B) == null ? void 0 : ((foo as A).bar as B)(foo.bar, false);