Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBindingIdentifiers should return params for private methods #13723

Merged
merged 6 commits into from Sep 2, 2021
Merged

getBindingIdentifiers should return params for private methods #13723

merged 6 commits into from Sep 2, 2021

Commits on Sep 2, 2021

  1. docs: add comments on binding kind

    @JLHwung
    JLHwung committed Sep 2, 2021
    Copy the full SHA
    1d775d0 View commit details
    Browse the repository at this point in the history

  2. refactor: simplify For collector visitor

    @JLHwung
    JLHwung committed Sep 2, 2021
    Copy the full SHA
    2dc2429 View commit details
    Browse the repository at this point in the history

  3. getBinding does not return falsy values

    @JLHwung
    JLHwung committed Sep 2, 2021
    Copy the full SHA
    eca3e1d View commit details
    Browse the repository at this point in the history

  4. chore: table style tests

    @JLHwung
    JLHwung committed Sep 2, 2021
    Copy the full SHA
    f2b2184 View commit details
    Browse the repository at this point in the history

  5. add more test cases

    @JLHwung
    JLHwung committed Sep 2, 2021
    Copy the full SHA
    b53b1e7 View commit details
    Browse the repository at this point in the history

  6. fix: return params for private methods

    @JLHwung
    JLHwung committed Sep 2, 2021
    Copy the full SHA
    5bfc350 View commit details
    Browse the repository at this point in the history