Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement @babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression #13842

Merged
merged 16 commits into from Oct 20, 2021
Merged

Implement @babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression #13842

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4368822
fix: register function expression id after params
JLHwung Oct 13, 2021
51c00f2
implement bugfix plugin
JLHwung Oct 13, 2021
d78f3fd
add more testcases
JLHwung Oct 13, 2021
0e31517
fix: do not skip pattern binding referencing id
JLHwung Oct 13, 2021
6d8e8c1
update compat-table
JLHwung Oct 13, 2021
b53a29a
add bugfix plugin to preset-env
JLHwung Oct 13, 2021
5632a4d
update Babel 8 test fixtures
JLHwung Oct 13, 2021
e354db3
Update packages/babel-plugin-bugfix-safari-id-destructuring-collision…
JLHwung Oct 13, 2021
4e90f11
chore: bundle bugfix plugin
JLHwung Oct 13, 2021
2aa123e
address review comments
JLHwung Oct 17, 2021
6d7bcd9
add runtime version check
JLHwung Oct 17, 2021
40748d2
update compat table
JLHwung Oct 19, 2021
faa978d
fix syntax error
JLHwung Oct 19, 2021
f8a2830
update test fixtures
JLHwung Oct 19, 2021
28ce449
revert bugfixes targets update
JLHwung Oct 20, 2021
c372660
update Babel 8 test fixtures
JLHwung Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...l-plugin-transform-react-constant-elements/test/fixtures/integration/issue-7610/output.js
View file
Open in desktop
Expand Up @@ -11,11 +11,12 @@ var _Child2 = babelHelpers.interopRequireDefault(require("./Child"));

var _jsxRuntime = require("react/jsx-runtime");

function MyComponent({
closeFn
}) {
function MyComponent(_ref) {
var _Child;

let {
closeFn
} = _ref;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is for Babel 8 only. We should work on enabling bugfixes by default in Babel 8.

return /*#__PURE__*/(0, _jsxRuntime.jsx)(_Parent.default, {
render: () => _Child || (_Child = /*#__PURE__*/(0, _jsxRuntime.jsx)(_Child2.default, {
closeFn: closeFn
Expand Down