Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow enum member without initializer after non-literal member #13865

Merged
merged 2 commits into from Oct 22, 2021
Merged

fix: allow enum member without initializer after non-literal member #13865

merged 2 commits into from Oct 22, 2021

Conversation

lightmare
Copy link
Contributor

@lightmare lightmare commented Oct 20, 2021 •
edited by nicolo-ribaudo

Q                       A
Fixed Issues? Fixes #13863
Patch: Bug Fix? ✔️
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 20, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7669065:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 20, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49314/

@nicolo-ribaudo nicolo-ribaudo added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Oct 20, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

JLHwung
JLHwung approved these changes Oct 21, 2021
View reviewed changes
packages/babel-plugin-transform-typescript/src/enum.ts Outdated
@@ -108,37 +108,43 @@ export function translateEnumValues(
): Array<[name: string, value: t.Expression]> {
const seen: PreviousEnumMembers = Object.create(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you also refactor seen into a Map?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JLHwung JLHwung merged commit cfe6739 into babel:main Oct 22, 2021
@lightmare lightmare deleted the fix-transform-typescript-enum branch October 23, 2021 00:55
@snyk-bot snyk-bot mentioned this pull request Dec 14, 2021
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript enum issue
4 participants
@lightmare @babel-bot @JLHwung @nicolo-ribaudo