Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add benchmarks for babel-types builders #13874

Merged
merged 1 commit into from Oct 23, 2021
Merged

add benchmarks for babel-types builders #13874

merged 1 commit into from Oct 23, 2021

Conversation

lightmare
Copy link
Contributor

@lightmare lightmare commented Oct 23, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? n/a
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? benchmark (devdeps) ➕ @babel/types
License MIT

Should've probably included those with #13843
I also added one for memberExpression to see how something less trivial than stringLiteral compares.

nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you post the results?

@lightmare
Copy link
Contributor Author 

$ yarn node --predictable benchmark/babel-types/builders/stringLiteral.mjs 
baseline stringLiteral builder: 5_782_124 ops/sec ±0.66% (0ms)
current stringLiteral builder: 8_939_235 ops/sec ±0.35% (0ms)

$ yarn node --predictable benchmark/babel-types/builders/memberExpression.mjs 
baseline memberExpression builder: 369_391 ops/sec ±0.47% (0.003ms)
current memberExpression builder: 413_608 ops/sec ±0.29% (0.002ms)

@nicolo-ribaudo nicolo-ribaudo merged commit 76a7e65 into babel:main Oct 23, 2021
@lightmare lightmare deleted the bench-builders branch October 24, 2021 10:26
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lightmare @JLHwung @nicolo-ribaudo