New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full import specifier path in tests #13938
Use full import specifier path in tests #13938
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49741/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a07e1a:
|
I missed some of them |
105eb94
to
9a07e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off-topic - Moved to #13966
If we bundle every package in Babel 8, how should we specify the path of imported modules, especially for those unit tests?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm moving this discussion to #13966. |
Since the main blocker for migrating to ESM (#13414) is Jest support (Jest reimplements the whole ESM linker, and it has some bugs + Node.js doesn't have a stable API to do it), I'm experimenting with a lightweight approach where I only use part of Jest and run the tests in a native Node.js environment.
I'm starting by only running the tests as ESM (rather than converting them to CJS on-the-fly), but in order to run them natively
import
statements must have the full path.