Convert proposal-object-rest-spread to TS #13948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49918/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 28355c5:
|
| const objectPatternPath = path.findParent(path => | ||
| path.isObjectPattern(), | ||
| //@ts-expect-error: findParent can not apply assertions on result shape | ||
| const objectPatternPath: NodePath<t.ObjectPattern> = path.findParent( |
There was a problem hiding this comment.
Not in this PR, but maybe something like this would work:
function findParent<T extends t.Node>(test: (path: NodePath<t.Node>) => path is NodePath<T>): T | null;
JLHwung
force-pushed
the
object-rest-spread-typings
branch
from
8096f11
to
e4c6d09
Compare
nicolo-ribaudo
approved these changes
Nov 19, 2021
existentialism
approved these changes
Nov 24, 2021
JLHwung
force-pushed
the
object-rest-spread-typings
branch
from
e4c6d09
to
d7b4dee
Compare
JLHwung
force-pushed
the
object-rest-spread-typings
branch
from
d7b4dee
to
46869b0
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted
proposal-object-rest-spreadto TS and fixed typing errors.