Add assertions to ExportNamedDeclaration without from
#13957
Merged
+195
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49785/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6cd651e:
|
sosukesuzuki
added
PR: Bug Fix 🐛
existentialism
approved these changes
Nov 15, 2021
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
|
Ok, it looks like it doesn't support it 😬 |
JLHwung
requested changes
Nov 15, 2021
sosukesuzuki
commented
Nov 15, 2021
| if (expect) { | ||
| this.unexpected(); | ||
| } else { | ||
| node.source = null; |
There was a problem hiding this comment.
Actually, node.source = null is called in maybeParseExportNamedSpecifiers and maybeParseExportDeclaration. So we can remove this from here.
JLHwung
approved these changes
Nov 15, 2021
nicolo-ribaudo
approved these changes
Nov 16, 2021
3 tasks
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
assertionstoExportNamedDeclarationwithoutfromwhenimportAssertionsis enabled.According to estree spec: