Fix handling of this&co in computed keys in arrows transform
#14005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
changed the title
this&co in computed keys in arrows transform
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50027/ |
JLHwung
approved these changes
Nov 29, 2021
Comment on lines
34
to
40
| Function(path: NodePath<t.Function>) { | ||
| // Methods will be handled by the Method visit | ||
| if (path.isMethod()) return; | ||
| // Arrow functions inherit their parent's environment | ||
| if (path.isArrowFunctionExpression()) return; | ||
| path.skip(); | ||
| }, |
There was a problem hiding this comment.
Can we remove it and add FunctionDeclaration and FunctionExpression to skipKey?
|
|
||
| // TODO (Babel 8): Don't export this function. | ||
| export function skipAllButComputedKey( | ||
| path: NodePath<t.Method | t.ClassProperty | t.ClassPrivateProperty>, |
There was a problem hiding this comment.
It seems to me that skipAllButComputedKey is not invoked on ClassPrivateProperty.
nicolo-ribaudo
force-pushed
the
this-computed-key-arrow
branch
from
19b5871
to
d27f33d
Compare
existentialism
approved these changes
Nov 30, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to extract
environmentVisitorto a new package to avoid circular deps between@babel/traverseand@babell/helper-replace-supers.