New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't resolve shadowed arguments
variables from functions
#14036
Merged
nicolo-ribaudo
merged 6 commits into
babel:main
from
The-x-Theorist:function-implicit-argument-binding-fail
Dec 13, 2021
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
64ead16
Fix: function's implicit argument binding failed
The-x-Theorist 872f92b
scope.rename only arrow functions
The-x-Theorist e497e07
CI errors fixed maybe
The-x-Theorist 0650f73
renamer won't rename arguments identifier inside function
The-x-Theorist 1e2f19b
explicit expect added for test implicit var arguments
The-x-Theorist 7094515
implicit-var-arguments test moved to transform-arrow-functions-plugin
The-x-Theorist File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...in-transform-arrow-functions/test/fixtures/arrow-functions/arguments-global-var/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...in-transform-arrow-functions/test/fixtures/arrow-functions/implicit-var-arguments/exec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
var arguments = [1, 2, 3]; | ||
var arr = () => arguments[0]; | ||
|
||
expect(arr()).toStrictEqual(1) | ||
|
||
function foo(n) { | ||
var f = () => arguments[0] + n; // foo's implicit arguments binding. arguments[0] is n | ||
return f(); | ||
} | ||
|
||
expect(foo(3)).toStrictEqual(6) |
10 changes: 10 additions & 0 deletions
10
...n-transform-arrow-functions/test/fixtures/arrow-functions/implicit-var-arguments/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
var arguments = [1, 2, 3]; | ||
var arr = (n) => arguments[0]; | ||
|
||
arr(4); // 1 | ||
|
||
function foo(n) { | ||
var f = () => arguments[0] + n; // foo's implicit arguments binding. arguments[0] is n | ||
return f(); | ||
} | ||
|
4 changes: 4 additions & 0 deletions
4
...ansform-arrow-functions/test/fixtures/arrow-functions/implicit-var-arguments/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"sourceType": "script", | ||
"plugins": ["transform-arrow-functions"] | ||
} |
18 changes: 18 additions & 0 deletions
18
...-transform-arrow-functions/test/fixtures/arrow-functions/implicit-var-arguments/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
var _arguments = [1, 2, 3]; | ||
|
||
var arr = function (n) { | ||
return _arguments[0]; | ||
}; | ||
|
||
arr(4); // 1 | ||
|
||
function foo(n) { | ||
var _arguments2 = arguments; | ||
|
||
var f = function () { | ||
return _arguments2[0] + n; | ||
}; // foo's implicit arguments binding. arguments[0] is n | ||
|
||
|
||
return f(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for self and others: this is correct, the test was previously broken —
fn
should not see the outerarguments
, because it was not an arrow function in input.js