Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin jest-worker to 27.3.1 in CRA e2e tests #14040

Merged
merged 2 commits into from Dec 11, 2021
Merged

Pin jest-worker to 27.3.1 in CRA e2e tests #14040

merged 2 commits into from Dec 11, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 10, 2021 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This should hopefully fix the failing e2e Babel 8 test. I also opened jestjs/jest#12128 to fix the regression in Jest (cc @SimenB, in case you missed that PR!), and nodejs/node#41103 to propose completely removing the error.

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 10, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50305/

@nicolo-ribaudo
Copy link
Member Author

It works: https://app.circleci.com/pipelines/github/babel/babel/8674/workflows/e6c22401-8160-45a1-8bc0-0886841100a2/jobs/50246

@SimenB
Copy link
Contributor

SimenB commented Dec 10, 2021

I did miss it! 😅 Published your fix now 🙂

@nicolo-ribaudo
Copy link
Member Author

Thanks!
I know that the Jest repo generates a lot of notifications, so I thought that pinging you here was a better approach 😛

@SimenB
Copy link
Contributor

SimenB commented Dec 10, 2021

Great plan! 😀

@nicolo-ribaudo
Copy link
Member Author

I'm merging this until CRA updates their lockfile to use the new jest-worker version.

@nicolo-ribaudo
Copy link
Member Author

I tried to update jest-worker and it fails, I will investigate 🤔

@nicolo-ribaudo
Copy link
Member Author

Uhhh, if I ssh into CircleCI it doesn't fail.

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Dec 11, 2021 •
edited

5348e6a shows that it's not a problem with the new jest-worker; it's just still using an older version.

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Dec 11, 2021 •
edited

@SimenB jest-worker is still broken when using the NODE_OPTIONS env variable, because of nodejs/node#41103 (comment). I'll open a PR with a workaround for Jest, but this really needs to be fixed in Node.js 😕

EDIT: jestjs/jest#12141

@nicolo-ribaudo
Copy link
Member Author

I removed the new commits: this PR still pins to 27.3.1.

@nicolo-ribaudo nicolo-ribaudo changed the title Pin jest-worker in CRA e2e tests Pin jest-worker to 27.2.1 in CRA e2e tests Dec 11, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 2d9fb7f into babel:main Dec 11, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-cra-e2e branch December 11, 2021 16:31
@nicolo-ribaudo nicolo-ribaudo changed the title Pin jest-worker to 27.2.1 in CRA e2e tests Pin jest-worker to 27.3.1 in CRA e2e tests Dec 11, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicolo-ribaudo @babel-bot @SimenB @existentialism @JLHwung