Convert ESLint plugins to CommonJS #14180
Merged
+117
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
nicolo-ribaudo
force-pushed
the
eslint-cjs
branch
from
dbe5c26 to
75e7519
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51301/ |
nicolo-ribaudo
force-pushed
the
eslint-cjs
branch
from
6a0ceca to
b770fda
Compare
nicolo-ribaudo
force-pushed
the
eslint-cjs
branch
from
b770fda to
3d64798
Compare
existentialism
approved these changes
Mar 3, 2022
JLHwung
approved these changes
Mar 3, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2ESLint doesn't support ESM, so plugins should be authored as CJS (similarly to how we do for
@babel/eslint-parser).I had to convert the files from TS to plain JS because TS doesn't support
.ctsyet, but they didn't contain any type annotation anyway.