Support merging sourcemaps when transformed file is fully replaced #14247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-up to babel#14246. I finally thought of a case where the sourceFileName's content is fully replaced, leading to only the injected file existing in the output sourcemap. This can happen where only one output source is created, or multiple. In the single output source case, we'd incorrectly associate the mappings through the inputMap, even though none of the content actually comes from there. In the multiple source case, we'd silently fail and output empty mappings. Both cases are now fixed, with the correct remapping being done through in all possible output cases now.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51185/ |
1 task
jridgewell
commented
Feb 7, 2022
| "@ampproject/remapping@npm:^2.0.0": | ||
| version: 2.0.2 | ||
| resolution: "@ampproject/remapping@npm:2.0.2" | ||
| "@ampproject/remapping@npm:^2.0.0, @ampproject/remapping@npm:^2.1.0": |
There was a problem hiding this comment.
I don't get yarn, but we need v2.1.0 to ensure the new ctx param is passed to the remapping loader. Will just the change in the package.json be enough?
nicolo-ribaudo
approved these changes
Feb 7, 2022
JLHwung
approved these changes
Feb 8, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #14246. I finally thought of a case where the
sourceFileName's content is fully replaced, leading to only the injected
file existing in the output sourcemap. This can happen where only one
output source is created, or multiple.
In the single output source case, we'd incorrectly associate the
mappings through the inputMap, even though none of the content actually
comes from there.
In the multiple source case, we'd silently fail and output empty mappings.
Both cases are now fixed, with the correct remapping being done through
in all possible output cases now.