Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source maps plain objects for use with t.valueToNode #14283

Merged
merged 2 commits into from Feb 17, 2022
Merged

Make source maps plain objects for use with t.valueToNode #14283

merged 2 commits into from Feb 17, 2022

Commits on Feb 17, 2022

  1. Make sourcemap plainobject for use w / valueToNode 

    When the sourcemaps were switched to use "@ampproject/remapping", the type
of the inputSourceMap that gets passed around changed from being a plain js
object to a `class SourceMap` fromthe remapping package. This causes issues
with the @babel/types valueToNode function because that function is defined
to throw for objects that aren't plain-objects.

In practice I was seeing this error after upgrading babel when running code-
coverage, and I saw a similar error reported here: vuejs/vue-jest#450 before
deciding to try to track the error down myself.
    Adam J. Hines committed Feb 17, 2022
    Copy the full SHA
    648c7a3 View commit details
    Browse the repository at this point in the history

  2. Simplify test

    @nicolo-ribaudo
    nicolo-ribaudo committed Feb 17, 2022
    Copy the full SHA
    cd37858 View commit details
    Browse the repository at this point in the history