Fix some minor (language, not code) syntax and type errors. #14352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51471/ |
|
Thanks! |
nicolo-ribaudo
changed the title
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR, in order to find out how to test the code, I carefully looked at all the files in the
/testdirectory, although I didn't find the right way in the end, but found some very minor issues, so I tried to fix them.The only point of contention may lie in the modification of the file
test/runtime-integration/bundlers.cjs. In the original file, I don't know the reason. At the end, the operation ofexpected = out;was executed, but later This variable is not used, so I don't think it makes sense, it should be a constant.