Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update decorators to match latest spec #14353

Merged
merged 12 commits into from Mar 18, 2022
Merged

Update decorators to match latest spec #14353

merged 12 commits into from Mar 18, 2022

Commits on Mar 17, 2022

  1. Update decorators to the latest spec 

    - Update `initialize` -> `init`
- Update decorator application ordering:
  1. Static method decorators
  2. Proto method decorators
  3. Static field decorators
  4. Proto field decorators
- Throw errors when `addInitializer` or metadata methods are called
  outside of decoration
    @pzuraq @nicolo-ribaudo
    pzuraq authored and nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    baef783 View commit details
    Browse the repository at this point in the history

  2. Smaller code (dedupe error message, managle prop name) 

    5236 -> 5003 bytes (after terser)
    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    b00d11d View commit details
    Browse the repository at this point in the history

  3. Wrap decorationFinishedRef in try/finally 

    size: 5024 -> 5048
    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    09bc0a1 View commit details
    Browse the repository at this point in the history

  4. Dedupe code (5069 -> 5009 bytes after terser)

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    8c766c4 View commit details
    Browse the repository at this point in the history

  5. Fix declaration error

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    5300321 View commit details
    Browse the repository at this point in the history

  6. Add tests

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    8f175ef View commit details
    Browse the repository at this point in the history

  7. Move tests

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    c3c60b2 View commit details
    Browse the repository at this point in the history

  8. Move test

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 17, 2022
    Copy the full SHA
    c1b63bb View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. For some reason console is not available in node 6

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 18, 2022
    Copy the full SHA
    bd2a20c View commit details
    Browse the repository at this point in the history

  2. Simplify helper

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 18, 2022
    Copy the full SHA
    e80c518 View commit details
    Browse the repository at this point in the history

  3. Simplify applyClassDecs

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 18, 2022
    Copy the full SHA
    c2bf48f View commit details
    Browse the repository at this point in the history

  4. Dedupe code

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 18, 2022
    Copy the full SHA
    b53e145 View commit details
    Browse the repository at this point in the history