Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scope info after destructuring transform #14494

Merged
merged 8 commits into from May 4, 2022
Merged

Update scope info after destructuring transform #14494

merged 8 commits into from May 4, 2022

Commits on Apr 26, 2022

  1. Introduce test suite for babel#14438 

    59/66 introduced tests failing
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    e53065d View commit details
    Browse the repository at this point in the history

  2. Attempt to fix babel#14438 

    Via crawling the scope after the transfomrations are made. 10/66 tests
passing instead of earlier 7/66.
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    d40dce6 View commit details
    Browse the repository at this point in the history

  3. Improve tests 

    Also test assumptions / preconditions
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    d84141c View commit details
    Browse the repository at this point in the history

  4. Fix babel#14438 

    1. Update tests: some were spurious failures
2. Address failing tests: introduce scope crawling in for statement
   cases
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    84d6c4a View commit details
    Browse the repository at this point in the history

  5. Take care of comments in JLHwung's review 

    - nit: improve variable naming style
- remove some manual scope updation code which isn't necessary now that
  we're crawling
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    d503eb7 View commit details
    Browse the repository at this point in the history

  6. Clear traverse scope cache for through testing 

    Ref: babel#14494 (comment)
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    ce4a6bf View commit details
    Browse the repository at this point in the history

  7. Move test to runnable plugin 

    See suggestions in JLHwung's review
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    8d1bb65 View commit details
    Browse the repository at this point in the history

  8. LVal.get('id') -> LVal.getBindingIdentifiers() 

    To generalize the check
    @peey
    peey committed Apr 26, 2022
    Copy the full SHA
    999fd51 View commit details
    Browse the repository at this point in the history