Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@babel/types builder improvements #14519

Merged
merged 17 commits into from May 9, 2022
Merged

@babel/types builder improvements #14519

merged 17 commits into from May 9, 2022

Commits on May 9, 2022

  1. improve deprecated builders generation

    @zxbodya @JLHwung
    zxbodya authored and JLHwung committed May 9, 2022
    Copy the full SHA
    1302e69 View commit details
    Browse the repository at this point in the history

  2. generate builders instead of dynamically doing it

    @zxbodya @JLHwung
    zxbodya authored and JLHwung committed May 9, 2022
    Copy the full SHA
    293f3fd View commit details
    Browse the repository at this point in the history

  3. use default parameters in builder function arguments

    @zxbodya @JLHwung
    zxbodya authored and JLHwung committed May 9, 2022
    Copy the full SHA
    f21d5f5 View commit details
    Browse the repository at this point in the history

  4. fix deprecated builders

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    050dd50 View commit details
    Browse the repository at this point in the history

  5. optimize: use shorthand if applicable

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    9c87b43 View commit details
    Browse the repository at this point in the history

  6. Mark BaseNode properties as optional 

    They are generated by `@babel/parser` but not returned from types builder
    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    7e540ff View commit details
    Browse the repository at this point in the history

  7. chore: improve types

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    91502a3 View commit details
    Browse the repository at this point in the history

  8. revert cloneNode changes

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    4f2bb2d View commit details
    Browse the repository at this point in the history

  9. fix: assign optional value when default is non-null

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    6e1ff5d View commit details
    Browse the repository at this point in the history

  10. optimize: skip validateNode when builder keys are empty

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    8dff475 View commit details
    Browse the repository at this point in the history

  11. fix: set default value of objectTypeAnnotation.indexers/callPropertie… 

    …s/internalSlots to []

null has been excluded by validate: arrayOfType
    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    06411a5 View commit details
    Browse the repository at this point in the history

  12. remove unused builder

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    181b281 View commit details
    Browse the repository at this point in the history

  13. fix deprecated types builder typings

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    c63fffb View commit details
    Browse the repository at this point in the history

  14. simplify builders

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    1a56005 View commit details
    Browse the repository at this point in the history

  15. return validated in validateNode

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    fbadf00 View commit details
    Browse the repository at this point in the history

  16. merge intermediate node declaration

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    2600b5a View commit details
    Browse the repository at this point in the history

  17. review comments

    @JLHwung
    JLHwung committed May 9, 2022
    Copy the full SHA
    38703fe View commit details
    Browse the repository at this point in the history