New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix flaky babel-cli test #14535
Conversation
JLHwung
commented
May 6, 2022
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Second attempt (after #14385) to fix flaky babel-cli test |
Patch: Bug Fix? | |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51892/ |
7d81952
to
14e20cf
Compare
We could also just retry the test 3 times if it fails. |
That would have to be implemented in the test executor. I am avoiding that since the |
We should probably use the Because inputs are sometimes merged. :)
|
19dcc93
to
02d39f1
Compare
02d39f1
to
6ea0e60
Compare
After 6ea0e60 I have run CI test for five times. The good news is that I didn't see one babel-cli test failing, the bad news is that this one surfaces to be our new flaky error:
|
Yeah, we have had that error for one week, I spend multiple hours debugging it but didn't come to a conclusion 😬 |
setTimeout(() => { | ||
console.error("EXECUTOR TIMEOUT"); | ||
process.exit(1); | ||
}, 5000); | ||
}, 20000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it can also be reverted.
...i/test/fixtures/babel/dir --out-dir --watch --verbose with external dependencies/executor.js
Outdated
Show resolved
Hide resolved
…-verbose with external dependencies/executor.js
I am merging with one 👍 because this PR only update test files. |