Enable the noImplicitThis tsc option
#14545
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51973/ |
JLHwung
changed the title
noImplicitThis tsc optionsnoImplicitThis tsc option
| @@ -127,7 +129,7 @@ export default declare((api, options: Options) => { | |||
| AssignmentExpression(path) { | |||
| const left = path.get("left"); | |||
| if (left.isIdentifier()) { | |||
| const localName = path.node.name; | |||
| const localName = left.node.name; | |||
There was a problem hiding this comment.
This is a bug fix. Babel does not replace module in module = {} to assertion errors because path.node.name is always undefined.
| throw new Error("The CommonJS '" + "exports" + "' variable is not available in ES6 modules." + "Consider setting setting sourceType:script or sourceType:unambiguous in your " + "Babel config for this file."); | ||
| }() + 4, function () { | ||
| throw new Error("The CommonJS '" + "exports" + "' variable is not available in ES6 modules." + "Consider setting setting sourceType:script or sourceType:unambiguous in your " + "Babel config for this file."); | ||
| }()); |
There was a problem hiding this comment.
I wonder if we can avoid emitting the error twice. I think it's duplicated because exports += 4 is handled like exports = exports + 4, so we emit one error for the read and one for the write.
There was a problem hiding this comment.
This is super low priority: since the generated code always throw, it's will almost never be included in production code.
JLHwung
force-pushed
the
enable-no-implicit-this
branch
2 times, most recently
from
ed94e39
to
efc934e
Compare
| if (!arg.isIdentifier()) return; | ||
| const localName = arg.node.name; | ||
| if (localName !== "module" && localName !== "exports") return; |
There was a problem hiding this comment.
This code change doesn't have any effect on the result, other than making the code "sound". If arg is not an identifier, arg.node.name is undefined and thus we returned.
|
|
||
| let type = this._getTypeAnnotation() || anyTypeAnnotation(); | ||
| export function getTypeAnnotation(this: NodePath): t.FlowType { | ||
| let type = this.getData("typeAnnotation"); |
There was a problem hiding this comment.
With this code change we use the internal map storage that NodePath supports, rather than just adding an extra property on the path object.
JLHwung
force-pushed
the
enable-no-implicit-this
branch
from
efc934e
to
dca76c4
Compare
JLHwung
force-pushed
the
enable-no-implicit-this
branch
from
dca76c4
to
47a8009
Compare
github-actions
bot
added
the
outdated
In this PR we enable the
noImplicitThiscompiler option and fixes all the new typing errors.This PR is based on #14530, whose changes implicitly fix
noImplicitThiserrors.