Improve module transform packages typings #14608

JLHwung · 2022-05-26T20:56:43Z

Q	A
License	MIT

See #14601 for more info.

JLHwung · 2022-05-26T20:58:16Z

packages/babel-plugin-transform-modules-systemjs/src/index.ts

              }
            } else if (path.isExportNamedDeclaration()) {
-              const declar = path.get("declaration");
+              const declar = path.node.declaration;


declar has been changed from a NodePath to Node for better type inference.

Probably it's also faster

babel-bot · 2022-05-26T20:59:23Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52078/

nicolo-ribaudo · 2022-05-27T19:50:39Z

packages/babel-plugin-transform-modules-amd/src/index.ts

+  const amdFactory = (
+    amdWrapper.get("expression.arguments") as NodePath<t.Expression>[]
+  )


We should annotate the wrapper parameter as t.ExpressionStatement (so that this type cast is guaranteed to be correct).

Also, it would probably be better to do const amdWrapper: NodePath<t.ExpressionStatement> = path.pushContainer("body", wrapper)[0] instead of type-casting here: it feels safer because we are making less assumptions about the code (we are just helping it to know that pushContainer returns its argument wrapped).

nicolo-ribaudo · 2022-05-27T19:51:31Z

packages/babel-plugin-transform-modules-amd/src/index.ts

-    .get("expression.arguments")
+  const amdFactory = (
+    amdWrapper.get("expression.arguments") as NodePath<t.Expression>[]
+  )
    .filter(arg => arg.isFunctionExpression())[0]


Nit (not related to this PR, but we can fix it here since it's small): .find() instead of .filter()[0].

nicolo-ribaudo · 2022-05-27T19:52:22Z

packages/babel-plugin-transform-modules-amd/src/index.ts

    .filter(arg => arg.isFunctionExpression())[0]
-    .get("body");
+    .get("body") as NodePath;


This should be NodePath<t.BlockStatement>, or NodePath<t.FunctionExpression["body"]>. Or maybe the .find change above already helps it inferring this type.

I split out expression.argumetns. The find is not sufficient because TS doesn't known the find must succeed. I end up querying the last argument and cast it to a FunctionExpression.

nicolo-ribaudo · 2022-05-27T19:53:23Z

packages/babel-plugin-transform-modules-systemjs/src/index.ts

+                  | t.ImportSpecifier
+                  | t.ImportDefaultSpecifier
+                  | t.ImportNamespaceSpecifier
+                  | t.ExportSpecifier
+                  | t.ExportDefaultSpecifier
+                  | t.ExportNamespaceSpecifier


Does t.ModuleSpecifier work here?

liuxingbaoyu · 2022-05-30T15:26:28Z

packages/babel-plugin-transform-modules-amd/src/index.ts

+    amdFactoryCallArgs[
+      amdFactoryCallArgs.length - 1
+    ] as NodePath<t.FunctionExpression>


Is it possible to use .at(-1) here?

No, we still need to support older node versions.

* enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * Improve transform-runtime typings (#14605) * enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-runtime typings Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * jsx (#14607) * Improve module transform packages typings (#14608) * improve babel-template typings (#14621) * Improve @babel/helper-* typings (#14620) * improve helper-function-name typings * helper hoist variables * helper-member-expression-to-functions * helper-simple-access * remap-async-to-generator * helper-annotate-as-pure * helper-builder-binary-assignment-operator-visitor * helper-check-duplicate-nodes * early return when export declaration is export all * split-export-declaration * helper-define-map * define-map * Update packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * review comments Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve helper-module-imports typings (#14623) * refactor: simplify ImportInjector._applyDefaults * helper-module-imports * map globals to the one used in Babel 8 * Improve fixture-test-runner typings (#14625) * plugin-test-runner * fixture-test-runner * Update packages/babel-helper-fixtures/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * Improve preset-env typings (#14606) * refactor: move shipped-proposals to ts * preset-env * address review comments * Improve pipeline-operator typings (#14629) * refactor: simplify buildOptimizedSequenceExpression * proposal-pipeline-operator * address review comments * improve standalone typings (#14630) * babel-standalone * address review comment * Improve plugins typings (Part 1) (#14633) * change AssumptionFunction return type * helper-create-regexp-features-plugin * create-class-features-plugin * transform-for-of * improve unicode-escapes typings * transform-object-super * transform-react-constant-elements * proto-to-assign * function-name * flow-comments TS cannot infer Flow visitor type because we have both Flow type and Flow virtual type. * Improve code-frame/hightlight typings (#14643) * code-frame * map js-tokens to Babel 8 * highlight * Improve `@babel/types` typings (#14645) * bump to-fast-properties to v4 * types * mark node comments as mutable * Improve babel-core typings (#14622) Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-classes typings (#14624) * Improve `@babel/generator` typings (#14644) * generator * refactor: merge {start,end}Terminatorless to printTerminatorless * inline buildYieldAwait * inline ExportDeclaration * also export Pos * let getPossibleRaw return string | void * Apply suggestions from code review Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * address review comments * do not export internal printer method * simplify needsWhitespace Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * Improve plugins typings (Part 2) (#14639) * exponentiation-operator * duplicate-keys * computed-properties * replace-supers * block-scoping * block-scoped-functions * syntax-typescript * record-and-tuple * private-property-in-object * partial-application * json-strings * function-sent * function-bind * class-static-block * async-generator-functions * Update packages/babel-plugin-transform-block-scoping/src/index.ts * address review comments * helper-replace-supers * Improve plugins typings (Part 3) (#14642) * external-helpers * bugfix * transform-parameters * object-rest-spread * destructuring-private * transform-destructuring * proposal-decorators * optional-chaining * helper-wrap-function * explode-assignable-expression * helper-compilation-targets * helper-plugin-utils * helpers * helper-validator-option * fix: allow "+" and "-" in MappedType .readonly/.optional * fixture-test-runner * remove charcodes from dependencies the charcodes transform will inline charCodes.* so we can remove it from dependencies * Improve traverse typings (#14648) * export removeProperties options * traverse * fix other packages typings * fix gatherNodeParts * downgrade to-fast-properties to v3 * fix typo * babel-core/normalize-file * add ignore comment property used by flow plugin * refine getLastStatement typings * fix babel-standalone rebase typing error * fix assert.rejects polyfill * simplify _param typings * supress Babel 7 AST errors * loosen defineType typings The AST typings are generated from defineType calls, so defineType should accept a string as type. * restore legacy code * Suppress data/core-js-compat importing errors Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>

JLHwung added 4 commits May 26, 2022 16:55

modules-umd

ba511a3

systemjs

0d7aa5e

helper-module-transforms

39bf0c8

module transforms

d9f57ea

JLHwung commented May 26, 2022

View reviewed changes

liuxingbaoyu approved these changes May 26, 2022

View reviewed changes

nicolo-ribaudo reviewed May 27, 2022

View reviewed changes

address review comments

0bb27b4

nicolo-ribaudo approved these changes May 30, 2022

View reviewed changes

liuxingbaoyu reviewed May 30, 2022

View reviewed changes

JLHwung merged commit 0f63772 into babel:noImplicitAny May 30, 2022

JLHwung deleted the noImplicitAny-module-transform branch May 30, 2022 17:02

JLHwung added a commit that referenced this pull request Jun 20, 2022

Improve module transform packages typings (#14608)

d08fa8a

JLHwung added a commit that referenced this pull request Jun 21, 2022

Improve module transform packages typings (#14608)

9e772e0

JLHwung added a commit that referenced this pull request Jun 21, 2022

Improve module transform packages typings (#14608)

000086d

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 30, 2022

github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve module transform packages typings #14608

Improve module transform packages typings #14608

JLHwung commented May 26, 2022 •

edited by gitpod-io bot

JLHwung May 26, 2022

nicolo-ribaudo May 27, 2022

babel-bot commented May 26, 2022 •

edited

nicolo-ribaudo May 27, 2022

nicolo-ribaudo May 27, 2022

nicolo-ribaudo May 27, 2022

JLHwung May 30, 2022

nicolo-ribaudo May 27, 2022

liuxingbaoyu May 30, 2022

nicolo-ribaudo May 30, 2022

Improve module transform packages typings #14608

Improve module transform packages typings #14608

Conversation

JLHwung commented May 26, 2022 • edited by gitpod-io bot

Choose a reason for hiding this comment

Choose a reason for hiding this comment

babel-bot commented May 26, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JLHwung commented May 26, 2022 •

edited by gitpod-io bot

babel-bot commented May 26, 2022 •

edited