Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plugins typings (Part 2) #14639

Merged
merged 18 commits into from Jun 18, 2022
Merged

Improve plugins typings (Part 2) #14639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b48b46d
exponentiation-operator
JLHwung May 25, 2022
951254b
duplicate-keys
JLHwung May 25, 2022
4003fa3
computed-properties
JLHwung May 25, 2022
f5165b2
replace-supers
JLHwung May 6, 2022
60d5844
block-scoping
JLHwung May 26, 2022
d49cc57
block-scoped-functions
JLHwung May 27, 2022
2b4bb62
syntax-typescript
JLHwung May 27, 2022
bc18c01
record-and-tuple
JLHwung May 27, 2022
28eadbb
private-property-in-object
JLHwung May 27, 2022
043a289
partial-application
JLHwung May 27, 2022
e70bca5
json-strings
JLHwung May 27, 2022
e0fc2b4
function-sent
JLHwung May 27, 2022
75e7ed1
function-bind
JLHwung May 27, 2022
ae3b18b
class-static-block
JLHwung May 30, 2022
4eeaa37
async-generator-functions
JLHwung May 30, 2022
ab68f2d
Update packages/babel-plugin-transform-block-scoping/src/index.ts
JLHwung Jun 6, 2022
0054372
address review comments
JLHwung Jun 6, 2022
3b0c873
helper-replace-supers
JLHwung May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts
View file
Open in desktop
Expand Up @@ -3,7 +3,13 @@ import { assignmentExpression, sequenceExpression } from "@babel/types";
import type { Visitor } from "@babel/traverse";
import type * as t from "@babel/types";

export default function (opts: { build: Function; operator: string }) {
export default function (opts: {
build: (
left: t.Expression | t.PrivateName,
right: t.BinaryExpression["right"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just t.Expression?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yes it is. I tried lowering left to t.Expression when operator is not in but failed.

) => t.Expression;
operator: t.BinaryExpression["operator"];
}) {
const { build, operator } = opts;

const visitor: Visitor = {
Expand Down
6 changes: 5 additions & 1 deletion packages/babel-plugin-transform-exponentiation-operator/src/index.ts
View file
Open in desktop
Expand Up @@ -14,7 +14,11 @@ export default declare(api => {
build(left, right) {
return t.callExpression(
t.memberExpression(t.identifier("Math"), t.identifier("pow")),
[left, right],
[
// left can be PrivateName only if operator is `"in"`
left as t.Expression,
right,
],
);
},
}),
Expand Down