Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plugins typings (Part 3) #14642

Merged
merged 17 commits into from Jun 18, 2022
Merged

Improve plugins typings (Part 3) #14642

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b71636b
external-helpers
JLHwung May 30, 2022
f5a47a9
bugfix
JLHwung May 30, 2022
3557925
transform-parameters
JLHwung May 30, 2022
3e8a350
object-rest-spread
JLHwung May 27, 2022
f020a33
destructuring-private
JLHwung May 30, 2022
cf4e32b
transform-destructuring
JLHwung May 30, 2022
bc2c2a3
proposal-decorators
JLHwung May 30, 2022
335905b
optional-chaining
JLHwung May 31, 2022
5c0fe59
helper-wrap-function
JLHwung May 31, 2022
ba2c2c9
explode-assignable-expression
JLHwung Jun 1, 2022
8ec9cb9
helper-compilation-targets
JLHwung Jun 1, 2022
c2820ce
helper-plugin-utils
JLHwung Jun 1, 2022
94fbc38
helpers
JLHwung Jun 1, 2022
44fad90
helper-validator-option
JLHwung Jun 1, 2022
ca1d2d4
fix: allow "+" and "-" in MappedType .readonly/.optional
JLHwung Jun 1, 2022
25a6885
fixture-test-runner
JLHwung Jun 8, 2022
acbde84
remove charcodes from dependencies
JLHwung Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-helper-fixtures/src/index.ts
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ export interface Test {
validateLogs: boolean;
}

interface TaskOptions extends InputOptions {
export interface TaskOptions extends InputOptions {
BABEL_8_BREAKING?: boolean;
DO_NOT_SET_SOURCE_TYPE?: boolean;
externalHelpers?: boolean;
Expand Down
12 changes: 9 additions & 3 deletions packages/babel-helper-transform-fixture-test-runner/src/index.ts
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ import {
resolveOptionPluginOrPreset,
type Test,
type TestFile,
type TaskOptions,
} from "@babel/helper-fixtures";
import { codeFrameColumns } from "@babel/code-frame";
import { TraceMap, originalPositionFor } from "@jridgewell/trace-mapping";
Expand Down Expand Up @@ -464,12 +465,17 @@ declare global {
}
}

export type SuiteOptions = {
ignoreSuites?: string[];
ignoreTasks?: string[];
};

export default function (
fixturesLoc: string,
name: string,
suiteOpts: any = {},
taskOpts: any = {},
dynamicOpts?: Function,
suiteOpts: SuiteOptions = {},
taskOpts: TaskOptions = {},
dynamicOpts?: (options: TaskOptions, task: Test) => void,
Comment on lines +476 to +478
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options are not used in our codebase, maybe we can remove them in Babel 8.

) {
const suites = getFixtures(fixturesLoc);

Expand Down