Improve `@babel/types` typings #14645

JLHwung · 2022-06-06T15:02:26Z

Q	A
Any Dependency Changes?	`to-fast-properties` is bumped to v4 (requires Node>=12.20) for Babel 8
License	MIT

See #14601 for more info. This PR improves @babel/types typings. to-fast-properties is bumped to v4 for Babel 8 since to-fast-properties@>=3.0 provides typings.

JLHwung · 2022-06-06T15:03:54Z

packages/babel-types/src/definitions/utils.ts

@@ -117,8 +123,8 @@ export function assertOneOf(...values: Array<any>): Validator {
  return validate;
 }

-export function assertNodeType(...types: Array<string>): Validator {
-  function validate(node, key, val) {
+export function assertNodeType(...types: NodeTypes[]): Validator {


The type checker will throw if we called assertNodeType with undefined node types.

babel-bot · 2022-06-06T15:06:11Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52167/

JLHwung · 2022-06-06T15:06:12Z

packages/babel-types/src/modifications/removeProperties.ts

+  "loc",
+  // Fixme: should be extra.raw / extra.rawValue?
+  "raw",
+  "rawValue",


It seems to be a bug, or they are for compatibility issues that I am not aware of.

This looks like a bug.

JLHwung · 2022-06-06T15:08:37Z

packages/babel-types/src/modifications/typescript/removeTypeDuplicates.ts

    types.push(bases[type]);
  }

  // add back in generics
  for (const name of Object.keys(generics)) {
-    types.push(generics[name]);
+    types.push(
+      // @ts-ignore generics are not implemented


The generics logic is implemented in #14393, I will revive that PR after current noImplicitAny works.

JLHwung · 2022-06-06T16:58:23Z

packages/babel-types/scripts/generators/ast-types.js

-  trailingComments?: ReadonlyArray<Comment> | null;
+  leadingComments?: Comment[] | null;
+  innerComments?: Comment[] | null;
+  trailingComments?: Comment[] | null;


comments are mutable because t.addComments explicitly mutates them.

nicolo-ribaudo · 2022-06-06T19:31:16Z

packages/babel-types/src/traverse/traverseFast.ts

 ): void {
  if (!node) return;

  const keys = VISITOR_KEYS[node.type];
  if (!keys) return;

-  opts = opts || {};
+  opts = opts || ({} as Options);


Can we somehow enforce at the type level that Options is a type compatible with empty objects? Maybe Options extends {}?

I didn't figure it out such a way.

TS complains {} is not assignable to Options even though {} satisfies Options' constraint, because one may pass an Options with required keys, to which {} is definitely not assignable. But in this case {} is unreachable anyway. So I think it is fine to leave it as-is.

* bump to-fast-properties to v4 * types * mark node comments as mutable

* enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * Improve transform-runtime typings (#14605) * enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-runtime typings Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * jsx (#14607) * Improve module transform packages typings (#14608) * improve babel-template typings (#14621) * Improve @babel/helper-* typings (#14620) * improve helper-function-name typings * helper hoist variables * helper-member-expression-to-functions * helper-simple-access * remap-async-to-generator * helper-annotate-as-pure * helper-builder-binary-assignment-operator-visitor * helper-check-duplicate-nodes * early return when export declaration is export all * split-export-declaration * helper-define-map * define-map * Update packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * review comments Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve helper-module-imports typings (#14623) * refactor: simplify ImportInjector._applyDefaults * helper-module-imports * map globals to the one used in Babel 8 * Improve fixture-test-runner typings (#14625) * plugin-test-runner * fixture-test-runner * Update packages/babel-helper-fixtures/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * Improve preset-env typings (#14606) * refactor: move shipped-proposals to ts * preset-env * address review comments * Improve pipeline-operator typings (#14629) * refactor: simplify buildOptimizedSequenceExpression * proposal-pipeline-operator * address review comments * improve standalone typings (#14630) * babel-standalone * address review comment * Improve plugins typings (Part 1) (#14633) * change AssumptionFunction return type * helper-create-regexp-features-plugin * create-class-features-plugin * transform-for-of * improve unicode-escapes typings * transform-object-super * transform-react-constant-elements * proto-to-assign * function-name * flow-comments TS cannot infer Flow visitor type because we have both Flow type and Flow virtual type. * Improve code-frame/hightlight typings (#14643) * code-frame * map js-tokens to Babel 8 * highlight * Improve `@babel/types` typings (#14645) * bump to-fast-properties to v4 * types * mark node comments as mutable * Improve babel-core typings (#14622) Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-classes typings (#14624) * Improve `@babel/generator` typings (#14644) * generator * refactor: merge {start,end}Terminatorless to printTerminatorless * inline buildYieldAwait * inline ExportDeclaration * also export Pos * let getPossibleRaw return string | void * Apply suggestions from code review Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * address review comments * do not export internal printer method * simplify needsWhitespace Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * Improve plugins typings (Part 2) (#14639) * exponentiation-operator * duplicate-keys * computed-properties * replace-supers * block-scoping * block-scoped-functions * syntax-typescript * record-and-tuple * private-property-in-object * partial-application * json-strings * function-sent * function-bind * class-static-block * async-generator-functions * Update packages/babel-plugin-transform-block-scoping/src/index.ts * address review comments * helper-replace-supers * Improve plugins typings (Part 3) (#14642) * external-helpers * bugfix * transform-parameters * object-rest-spread * destructuring-private * transform-destructuring * proposal-decorators * optional-chaining * helper-wrap-function * explode-assignable-expression * helper-compilation-targets * helper-plugin-utils * helpers * helper-validator-option * fix: allow "+" and "-" in MappedType .readonly/.optional * fixture-test-runner * remove charcodes from dependencies the charcodes transform will inline charCodes.* so we can remove it from dependencies * Improve traverse typings (#14648) * export removeProperties options * traverse * fix other packages typings * fix gatherNodeParts * downgrade to-fast-properties to v3 * fix typo * babel-core/normalize-file * add ignore comment property used by flow plugin * refine getLastStatement typings * fix babel-standalone rebase typing error * fix assert.rejects polyfill * simplify _param typings * supress Babel 7 AST errors * loosen defineType typings The AST typings are generated from defineType calls, so defineType should accept a string as type. * restore legacy code * Suppress data/core-js-compat importing errors Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>

JLHwung added 2 commits June 6, 2022 10:58

bump to-fast-properties to v4

71f919d

types

5112d5f

JLHwung commented Jun 6, 2022

View reviewed changes

mark node comments as mutable

3298418

JLHwung commented Jun 6, 2022

View reviewed changes

nicolo-ribaudo reviewed Jun 6, 2022

View reviewed changes

nicolo-ribaudo approved these changes Jun 6, 2022

View reviewed changes

existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jun 8, 2022

existentialism approved these changes Jun 8, 2022

View reviewed changes

JLHwung merged commit b22e21b into babel:noImplicitAny Jun 8, 2022

JLHwung deleted the noImplicitAny-types branch June 8, 2022 16:48

JLHwung added a commit that referenced this pull request Jun 20, 2022

Improve @babel/types typings (#14645)

3ea406d

* bump to-fast-properties to v4 * types * mark node comments as mutable

JLHwung added a commit that referenced this pull request Jun 21, 2022

Improve @babel/types typings (#14645)

11d7e6b

* bump to-fast-properties to v4 * types * mark node comments as mutable

JLHwung added a commit that referenced this pull request Jun 21, 2022

Improve @babel/types typings (#14645)

00eaf46

* bump to-fast-properties to v4 * types * mark node comments as mutable

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 8, 2022

github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve `@babel/types` typings #14645

Improve `@babel/types` typings #14645

JLHwung commented Jun 6, 2022 •

edited by gitpod-io bot

JLHwung Jun 6, 2022

babel-bot commented Jun 6, 2022 •

edited

JLHwung Jun 6, 2022

nicolo-ribaudo Jun 6, 2022

JLHwung Jun 6, 2022

JLHwung Jun 6, 2022 •

edited

nicolo-ribaudo Jun 6, 2022

JLHwung Jun 7, 2022

Improve @babel/types typings #14645

Improve @babel/types typings #14645

Conversation

JLHwung commented Jun 6, 2022 • edited by gitpod-io bot

JLHwung Jun 6, 2022

Choose a reason for hiding this comment

babel-bot commented Jun 6, 2022 • edited

JLHwung Jun 6, 2022

Choose a reason for hiding this comment

nicolo-ribaudo Jun 6, 2022

Choose a reason for hiding this comment

JLHwung Jun 6, 2022

Choose a reason for hiding this comment

JLHwung Jun 6, 2022 • edited

Choose a reason for hiding this comment

nicolo-ribaudo Jun 6, 2022

Choose a reason for hiding this comment

JLHwung Jun 7, 2022

Choose a reason for hiding this comment

Improve `@babel/types` typings #14645

Improve `@babel/types` typings #14645

JLHwung commented Jun 6, 2022 •

edited by gitpod-io bot

babel-bot commented Jun 6, 2022 •

edited

JLHwung Jun 6, 2022 •

edited