Remove Super from Expression alias
#14750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JLHwung
commented
Jul 12, 2022
•
JLHwung
commented
| Q | A |
|---|---|
| Fixed Issues? | #14739 (comment) |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | babel/website#2765 |
| Any Dependency Changes? | |
| License | MIT |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52487/ |
JLHwung
force-pushed
the
remove-super-from-expression
branch
from
8b59890
to
4476644
Compare
JLHwung
commented
Jul 12, 2022
| @@ -653,7 +653,7 @@ describe("scope", () => { | |||
| describe("duplicate declaration", () => { | |||
| it("should not throw error on duplicate class and function declaration", () => { | |||
| const ast = [ | |||
| t.classDeclaration(t.identifier("A"), t.super(), t.classBody([]), []), | |||
| t.classDeclaration(t.identifier("A"), null, t.classBody([]), []), | |||
There was a problem hiding this comment.
class A extends super {} is invalid.
JLHwung
commented
Jul 12, 2022
Comment on lines
+178
to
+182
| callee.object = t.assignmentExpression( | ||
| "=", | ||
| temp, | ||
| // object must not be Super when `temp` is an identifier | ||
| callee.object as t.Expression, |
There was a problem hiding this comment.
It is pretty annoying that we can't have TS narrowed down the object type in such pattern const foo = scope.maybeGenerateMemoised(object); if (foo) { // object must not be Super | TopicReference ... }. I tried conditional type like
maybeGenerateMemoised<T extends t.Node>(object: T): T extends t.Super ? null : t.IdentifierTS can infer maybeGenerateMemoised returns null when object is Super, but it can't infer T from the return results.
JLHwung
force-pushed
the
remove-super-from-expression
branch
from
432acf6
to
3835ae1
Compare
liuxingbaoyu
approved these changes
Jul 13, 2022
nicolo-ribaudo
approved these changes
Jul 13, 2022
nicolo-ribaudo
changed the title
Super from Expression alias
github-actions
bot
added
the
outdated
JLHwung
added
PR: Breaking Change 💥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.