Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helper-wrap-function compat with old traverse #14825

Merged
merged 1 commit into from Aug 4, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 3, 2022

Q                       A
Fixed Issues? Fixes #14822, fixes #14824
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

A follow-up to #14752. In this PR we fix compatibility issue with @babel/traverse < 7.18.10.

For those affected by this issue, you don't have to wait for this fix. Instead you can upgrade @babel/traverse to the latest version.

@JLHwung JLHwung added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 3, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52667/

@nicolo-ribaudo nicolo-ribaudo changed the title fix: helper-wrap-function compat with traverse fix: helper-wrap-function compat with old traverse Aug 4, 2022
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the only cause of the problem, but it could have been merged first.

#14822 (comment)

@JLHwung JLHwung merged commit 916ee46 into babel:main Aug 4, 2022
@JLHwung JLHwung deleted the fix-14822 branch August 4, 2022 12:09
@JLHwung
Copy link
Contributor Author

JLHwung commented Aug 4, 2022

Nextjs bundled babel/core so some users may have to wait until the fix gets shipped to nextjs.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
4 participants