Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorators updates for 7.19.0 #14859

Merged
merged 3 commits into from Sep 5, 2022
Merged

Decorators updates for 7.19.0 #14859

merged 3 commits into from Sep 5, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 16, 2022

⚠️ Use the "Rebase and merge" button!

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 16, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52869/

@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.19.0/decorators branch 2 times, most recently from 4d69407 to 08bd28c Compare August 24, 2022 14:59
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Aug 31, 2022
nicolo-ribaudo and others added 3 commits September 2, 2022 18:08
* Copy `applyDecs`->`applyDecs2203` helper, and `2021-12`->`2022-03` tests

* Avoid conflicting fn names in helpers

* Add `2022-03` decorators version

* Rename `isPrivate`/`isStatic`->`private`/`static`

* Disallow `@(...)()` in 2022-03 decorators

This commits add a new `allowCallParenthesized` option to the decorators parser plugin:
when set to `false`, `@(...)()`-style decorators are allowed to match the stage 3
proposal presented in March 2022.

It will default to `false` in Babel 8 (we might just remove the option)

* Disallow `decoratorsBeforeExport` option with 2022-03 decorators

This aligns with the Babel 8 behavior

* Remove `.initializer` fallback for accessor properties

* Remove `.initializer` fallback for accessor properties

* Expose `.access` for public class elements

* Remove `getMetadata`/`setMetadata`

* Make the parser error recoverable

* Print necessary parentheses in generator
@nicolo-ribaudo nicolo-ribaudo merged commit 16d3220 into main Sep 5, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the feat-7.19.0/decorators branch September 5, 2022 14:07
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release umbrella ☂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants